-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Speed up equalize transform: use bincount instead of histc #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fmassa
merged 8 commits into
pytorch:master
from
NicolasHug:use_bincount_instead_of_hist
Mar 8, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3ff0ea9
use bincount instead of hist
NicolasHug 349c88a
only use bincount when on CPU
NicolasHug d361842
Merge branch 'master' of github.com:pytorch/vision into use_bincount_…
NicolasHug 18f1b8c
Merge branch 'master' of github.com:pytorch/vision into use_bincount_…
NicolasHug 87c43ec
Added equality test for CPU vs cuda
NicolasHug f970fb2
Fix flake8 and tests
NicolasHug 5cf9e0b
Merge branch 'master' of github.com:pytorch/vision into use_bincount_…
NicolasHug c294ec0
tuple instead of int for size
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to clip values between 0 and 255 to keep things consistent between cuda/cpu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing
minlength=256
ensures thatbincount
will count the number of values for all values in[0, 255]
, sohistc
andbincount
would be equivalent.In the
histc
call we havebins=256, min=0, max=255
, which IIUC assumes that the image is within[0, 255]
already, is this not the case?