-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Make DatasetFolder.find_classes public #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @alemelis! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @alemelis
torchvision/datasets/folder.py
Outdated
@@ -203,7 +203,7 @@ def make_dataset( | |||
return make_dataset(directory, class_to_idx, extensions=extensions, is_valid_file=is_valid_file) | |||
|
|||
@staticmethod | |||
def _find_classes(dir: str) -> Tuple[List[str], Dict[str, int]]: | |||
def find_classes(dir: str) -> Tuple[List[str], Dict[str, int]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this an instance method too and remove the @staticmethod
following #3496 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we'll need docs now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep instance method makes sense
there's already a quite detailed doctstring in find_classes()
function, shall I move it to this method instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link to find_classes()
and write something like
Same as :func:
find_classes
. This method can be overridden to only consider a subset of classes, or to adapt to a different dataset directory structure.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit but LGTM, thanks!
Co-authored-by: Nicolas Hug <[email protected]>
@alemelis before we merge would you mind looking into the linting and test issues? |
./torchvision/datasets/folder.py:207:1: W293 blank line contains whitespace ./torchvision/datasets/folder.py:208:55: W291 trailing whitespace
Since I'm pushing from a fork, is there an additional step I should follow to fix this? |
Thanks @alemelis ! |
Thanks @alemelis for the PR and @NicolasHug for the review! |
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: NicolasHug Differential Revision: D27706955 fbshipit-source-id: da038e3b92aa47a720b45f3b6ea4a48976e15ed2
Closes #3627