deprecate tests/fakedata_generation.py
#3735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pmeier , I'll import the PR to fbcode and report back |
|
Sorry for the delay on this, syncing was hectic lately. This PR does seem to break fbcode as one of the classyvision test is relying on this file. I'll try to see with them what can be done about this. For ref the diff is D28568302 (fb internal only) |
|
@NicolasHug could you try again? I fixed some logic and it should work now. |
|
Closed by #4130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3705 the last dataset was converted to the new test architecture. Thus,
tests/fakedata_generation.pyis no longer needed. Some internal FB code depends on theCIFARfakedata generation. Thus, we leave them here in a BC way.This should not be merged until it passes the FB internal checks.