[docs] descriptive comments of the decoder C++ api #3754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI clang-format is failing |
|
Clang is now passing; @prabhat00155 could you give it a pass for a merge once the rebase checks are done? |
prabhat00155
reviewed
Jun 9, 2021
| // fill it with minimal information about the format (codecs are not opened | ||
| // here). Function reads in intformation about the streams from the container | ||
| // into inputCtx and then passes it to decoder::openStreams. Finally, if seek is | ||
| // specified, it seeks into the correct frame (note, the seek defined here is |
There was a problem hiding this comment.
How do we specify seek here?
There was a problem hiding this comment.
There is a flag for fast seek implementation within decoder metadata. You can see the implementation (and we should try fbsync it once we're back from vacation here) #3179
|
Hey @datumbox! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Summary: * document video_sampler. * minor docs for decoder.cpp * descriptive comments for the stream.c * descriptive comments for decoder.cpp * per-stream descriptive comments * Fixing CLANG hopefully * addressing prabhat's comments * typo I think Reviewed By: NicolasHug Differential Revision: D30417191 fbshipit-source-id: bde05093540de56b65b20900aa252b597768f00d Co-authored-by: Francisco Massa <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a more descriptive commenting of parts of the decoder API in an effort to move the documentation forward. No actually code has been changed.