port tests in test_functional_tensor to pytest #3977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Thanks @sahilg06 ! This looks great, I only have some minor cosmetics comments, but LGTM when green!
test/test_functional_tensor.py
Outdated
| @@ -1141,5 +1003,148 @@ def test_adjust_gamma(device, dtype, config): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('device', cpu_and_gpu()) | |||
| @pytest.mark.parametrize('func, args', [(F_t._get_image_size, ()), (F_t.vflip, ()), | |||
There was a problem hiding this comment.
It's no big deal but I find this formatting to be a bit cleaner, and easier to read:
@pytest.mark.parametrize('func, args', [
(F_t._get_image_size, ()),
(F_t.vflip, ()),
(F_t.hflip, ()),
(F_t.crop, (1, 2, 4, 5)),
(F_t.adjust_brightness, (0., )),
(F_t.adjust_contrast, (1., )),
...
])
test/test_functional_tensor.py
Outdated
|
|
||
|
|
||
| @pytest.mark.parametrize('device', cpu_and_gpu()) | ||
| @pytest.mark.parametrize('top,left,height,width', [(1, 2, 4, 5), # crop inside top-left corner |
There was a problem hiding this comment.
We could do something similar here
test/test_functional_tensor.py
Outdated
Comment on lines
1110
to
1116
| if image_size == 'small': | ||
|
|
||
| tensor = torch.from_numpy( | ||
| np.arange(3 * 10 * 12, dtype="uint8").reshape((10, 12, 3)) | ||
| ).permute(2, 0, 1).to(device) | ||
|
|
||
| else: |
There was a problem hiding this comment.
no need to skip lines here:
Suggested change
| if image_size == 'small': | |
| tensor = torch.from_numpy( | |
| np.arange(3 * 10 * 12, dtype="uint8").reshape((10, 12, 3)) | |
| ).permute(2, 0, 1).to(device) | |
| else: | |
| if image_size == 'small': | |
| tensor = torch.from_numpy( | |
| np.arange(3 * 10 * 12, dtype="uint8").reshape((10, 12, 3)) | |
| ).permute(2, 0, 1).to(device) | |
| else: |
Yes ;), I tend to approve early when the requested changes are easy / obvious. I sometimes make comments that don't really need to be addressed and for those I usually say they're Nits. The comments here were bordeline nits. Thanks a lot for the PR! |
6 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
Reviewed By: NicolasHug Differential Revision: D29027349 fbshipit-source-id: dcf94ab9ba52af22b3274edc96f70ac66ae9f397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the following tests to pytest in the file test/test_functional_tensor.py mentioned in issue #3956
Group A
Group E