Skip to content

Removed test_audio_video_sync as it doesn't work as expected #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

Removed test_audio_video_sync as it doesn't work as expected #4050

merged 1 commit into from
Jun 11, 2021

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Jun 11, 2021 •
edited
Loading

test_audio_video_sync is very slow and doesn't work as expected on audio stream. There are some differences with pyav results as reported here, which needs to be fixed first.
Resolves #3931.

datumbox
datumbox approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Note:
We are removing the specific test because:

  1. It blocks the merge of bug fixes.
  2. It does not work properly or protects us from issues
  3. It's very slow

We will replace this once the issues on audio/video reading are fixed.

@prabhat00155 prabhat00155 merged commit 9766f23 into pytorch:master Jun 11, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/remove_test branch June 11, 2021 16:24
@fmassa
Copy link
Member

fmassa commented Jun 14, 2021

Do we have an issue to track adding the new tests again?

facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
@NicolasHug @facebook-github-bot
[fbsync] Removed test_audio_video_sync as it doesn't work as expected (…
2ad5ba8 
…#4050)

Reviewed By: fmassa

Differential Revision: D29097708

fbshipit-source-id: accd0d11c1240c07fd3fd5483238eeec6c8b4a8d
@prabhat00155 prabhat00155 mentioned this pull request Jun 15, 2021
Open
3 tasks
@prabhat00155
Copy link
Contributor Author

Do we have an issue to track adding the new tests again?

@fmassa Yes, #3986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: tests module: video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up the test_audio_video_sync unit-test
4 participants
@prabhat00155 @fmassa @datumbox @facebook-github-bot