Fixed missing audio with pyav backend #4064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat00155
requested review from
fmassa and
bjuncek
and removed request for
fmassa
datumbox
reviewed
Jun 28, 2021
bjuncek
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
This looks good to me.
Thanks @prabhat00155 for the good work.
@datumbox does my comment addresses your reservations?
datumbox
approved these changes
Jul 14, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
Reviewed By: fmassa Differential Revision: D29932691 fbshipit-source-id: 1edbf407c2c8b08dd7df693da5ca3ae0d7da6d3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3779.
_align_audio_frames() expects start_pts and end_pts passed in
pts. If we pass non-default start_pts and end_pts values, this causes the issue.Another problem that's fixed here happens when passing start_pts and end_pts in
pts. In the current implementation, this would lead to incorrectly reading the audio stream between video stream's start_pts and end_pts.Fix:
sectoptsunit before calling _align_audio_frames().