Fixed missing audio with pyav backend #4064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3779.
_align_audio_frames() expects start_pts and end_pts passed in
pts
. If we pass non-default start_pts and end_pts values, this causes the issue.Another problem that's fixed here happens when passing start_pts and end_pts in
pts
. In the current implementation, this would lead to incorrectly reading the audio stream between video stream's start_pts and end_pts.Fix:
sec
topts
unit before calling _align_audio_frames().