-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Raise proper error when deconding 16-bits jpegs #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And there may be 32-bit or 64-bit png images. And I'm not sure the case of jpg. |
NicolasHug
reviewed
Jun 23, 2021
Thanks @cyyever ! |
Thanks for the fix @cyyever ! |
cyyever
added a commit
to cyyever/vision
that referenced
this pull request
Jun 24, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
Reviewed By: NicolasHug Differential Revision: D29369895 fbshipit-source-id: c0203152ccf006578c70e1e9201bb168089ff938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, I found that #3613 failed because the image is 16 bit. However our decoding code assumes the image is 8-bit. So our allocated tensor size is too small to hold the decoded data and leads to memory overflow.
However, I can't find an easy way to decode 16-bit images without breaking the current decoding logic(we would have to change too many code places). So I simply issue an error.
Note: In order to support 16-bit png images, we should allocate the tensor with torch::kI16 and change
and
and the logic of read_callback. And although #4051 didn't fix this bug, I still think it's useful..