Added typing annotations to io/__init__ #4224
Conversation
| return self | ||
|
|
||
| def seek(self, time_s: float): | ||
| def seek(self, time_s: float) -> 'VideoReader': |
There was a problem hiding this comment.
Could be replaced with VideoReader once we drop Python 3.6 support. See here.
There was a problem hiding this comment.
Nice.
I learn something new everyday because of review from torchvision maintainers 😇
There are couple of more places where I have used this workaround in typing in torchvision. I will keep a note of this point.
There was a problem hiding this comment.
@datumbox yup fully agree! But for now (this PR), I guess we keep the string version?
There was a problem hiding this comment.
yes that's right, nothing we can do for now.
| @@ -126,10 +127,10 @@ def __next__(self): | |||
| raise StopIteration | |||
| return {"data": frame, "pts": pts} | |||
|
|
|||
| def __iter__(self): | |||
| def __iter__(self) -> Iterator['VideoReader']: | |||
|
@frgfm could you please merge master to clear the CI errors? |
|
@datumbox all errors were cleared after the previous merge 👌 |
Summary: * style: Added typing annotations * Specified types for iter and seek. Reviewed By: fmassa Differential Revision: D30793319 fbshipit-source-id: b5d3a220639d239f64cee6712aa07e19fdaaf875 Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
Following up on #2025, this PR adds missing typing annotations in
io/__init__.py.Note to reviewers: I'm not sure about the return types when a method returns
self🤷♂️Any feedback is welcome!