Added typing annotations to transforms/autoaugment #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
FYI: I removed the ignore from mypy.ini locally and the checks are all passing on my end now 👌 |
oke-aditya
reviewed
Aug 2, 2021
fmassa
approved these changes
Aug 4, 2021
|
before merging, we should please remove this file from mypy's ignore list so that the CI can check it as mentioned in #2025 (comment) |
Correct, but I thought we could merge #4236 before (otherwise we're gonna get conflicts about the mypy.ini on all related PRs), then I'll merge master and edit on this branch (+ the edit suggested by @fmassa ) |
|
That sounds good to me, as long as we don't forget the CI :) |
|
Hey @datumbox! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Summary: * style: Added typing annotations * style: Fixed typing * style: Fixed typing * Remove unnecessary any. * Update mypy.ini Reviewed By: NicolasHug Differential Revision: D30417197 fbshipit-source-id: c801be04c456b4ec6c7794b9b1c89a79fe8773c6 Co-authored-by: Francisco Massa <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2025, this PR adds missing typing annotations in transforms/autoaugment.py.
Any feedback is welcome!