Add a test that compares the output of our quantized models against expected cached values #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vasilis Vryniotis <[email protected]>
…ision into output-checks-on-quant-models
jdsgomes
changed the title
jdsgomes
changed the title
|
Thanks for the review @datumbox ! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
…against expected cached values (#4597) Summary: * adding tests to check output of quantized models * adding test quantized model weights * merge test_new_quantized_classification_model with test_quantized_classification_model * adding skipif removed by mistake * addressing comments from PR * removing unused argument * fixing lint errors * changing model to eval model and updating weights * Update test/test_models.py * enforce single test in circleci * changing random seed * updating weights for new seed * adding missing empty line * try 128 random seed * try 256 random seed * try 16 random seed * disable inception_v3 input/output quantization tests * removing ModelTester.test_inception_v3_quantized_expect.pkl * reverting temporary ci run_test.sh changes Reviewed By: fmassa Differential Revision: D31649962 fbshipit-source-id: 35a0cb4d8d3564c88dabc09e750d5ad0a281431a Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
…xpected cached values (pytorch#4597) * adding tests to check output of quantized models * adding test quantized model weights * merge test_new_quantized_classification_model with test_quantized_classification_model * adding skipif removed by mistake * addressing comments from PR * removing unused argument * fixing lint errors * changing model to eval model and updating weights * Update test/test_models.py Co-authored-by: Vasilis Vryniotis <[email protected]> * enforce single test in circleci * changing random seed * updating weights for new seed * adding missing empty line * try 128 random seed * try 256 random seed * try 16 random seed * disable inception_v3 input/output quantization tests * removing ModelTester.test_inception_v3_quantized_expect.pkl * reverting temporary ci run_test.sh changes Co-authored-by: Vasilis Vryniotis <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
…xpected cached values (pytorch#4597) * adding tests to check output of quantized models * adding test quantized model weights * merge test_new_quantized_classification_model with test_quantized_classification_model * adding skipif removed by mistake * addressing comments from PR * removing unused argument * fixing lint errors * changing model to eval model and updating weights * Update test/test_models.py Co-authored-by: Vasilis Vryniotis <[email protected]> * enforce single test in circleci * changing random seed * updating weights for new seed * adding missing empty line * try 128 random seed * try 256 random seed * try 16 random seed * disable inception_v3 input/output quantization tests * removing ModelTester.test_inception_v3_quantized_expect.pkl * reverting temporary ci run_test.sh changes Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4502
cc @datumbox @pmeier