Avoid weight download on test_detection_model_trainable_backbone_layers test
#4659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
approved these changes
Oct 19, 2021
| @@ -783,7 +783,7 @@ def test_detection_model_trainable_backbone_layers(model_name): | |||
| n_trainable_params = [] | |||
| for trainable_layers in range(0, max_trainable + 1): | |||
| model = torchvision.models.detection.__dict__[model_name]( | |||
| pretrained=False, pretrained_backbone=True, trainable_backbone_layers=trainable_layers | |||
| pretrained=False, pretrained_backbone=False, trainable_backbone_layers=trainable_layers | |||
There was a problem hiding this comment.
Related test failures? I see a bunch of detection model tests failing.
There was a problem hiding this comment.
Thanks for the flag. Yes they are related.
The value of the boolean unfortunately affects the number of unfrozen weights... I think we need to rethink how we test this cause we shouldn't be downloading any weights without having setup a caching mechanism.
I think I'm going to close the PR and review how to solve this on a follow up PR.
cc @jdsgomes
There was a problem hiding this comment.
New issue created at #4660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests shouldn't download the backbone weights.