Skip to content

Fix reduce_across_processes() inconsistent return type #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 25, 2021

Alternative to #4722

@datumbox This is different to what I suggested in https://github.com/pytorch/vision/pull/4722/files#r735476660 but probably simpler/cleaner

cc @datumbox

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NicolasHug NicolasHug merged commit 3783f3f into pytorch:main Oct 25, 2021
facebook-github-bot pushed a commit that referenced this pull request Oct 26, 2021
Reviewed By: NicolasHug

Differential Revision: D31916337

fbshipit-source-id: ffa6b8ff392a5459a10a2b0c0d8f0f6350b92fde
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants