-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Multi-weight support for DeepLabV3 prototype models #4757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit d42fac6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've added a couple of comments, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary: * adding multiweight support for deeplabv3 prototype models * adding default values for optional params * fixing bug * addressing PR comment Reviewed By: datumbox Differential Revision: D32064686 fbshipit-source-id: caf64b687b381915388b7f6723a77d2cd1cd56b8
* adding multiweight support for deeplabv3 prototype models * adding default values for optional params * fixing bug * addressing PR comment
closes #4677
cc @datumbox @bjuncek