Skip to content

More robust test_random_apply and test_random_choice #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 28, 2021

As a follow up to #4756

If the angle is too low the check might fail (https://app.circleci.com/pipelines/github/pytorch/vision/11954/workflows/3441b4a8-fcb8-4342-9823-5178ba8a8f33/jobs/935323), so we're now making sure it's > 45 degrees

cc @vfdev-5 @datumbox @pmeier

@facebook-github-bot
Copy link

facebook-github-bot commented Oct 28, 2021

💊 CI failures summary and remediations

As of commit a5e6375 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_libtorchvision_ops_ios_12.0.0_arm64 Update Homebrew 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NicolasHug NicolasHug merged commit f5af07b into pytorch:main Nov 4, 2021
facebook-github-bot pushed a commit that referenced this pull request Nov 8, 2021
Reviewed By: kazhang

Differential Revision: D32216679

fbshipit-source-id: 49882628485d0749c60422266c4ad98707904420
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants