Skip to content

Adding multiweight support for shufflenetv2 prototype model #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 29, 2021

Conversation

jdsgomes
Copy link
Contributor

@jdsgomes jdsgomes commented Oct 29, 2021

Addresses #4672

cc @datumbox @vfdev-5 @bjuncek

PS: apologies for the messy PR!

@facebook-github-bot
Copy link

facebook-github-bot commented Oct 29, 2021

💊 CI failures summary and remediations

As of commit f3efb57 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdsgomes. Overall it looks good, I just spotted one issue that needs to be corrected. Let me know what you think.

@jdsgomes
Copy link
Contributor Author

Thanks @jdsgomes. Overall it looks good, I just spotted one issue that needs to be corrected. Let me know what you think.

Well-spotted , thank you.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox linked an issue Oct 29, 2021 that may be closed by this pull request
@datumbox datumbox merged commit 4dff496 into pytorch:main Oct 29, 2021
facebook-github-bot pushed a commit that referenced this pull request Nov 1, 2021
…4792)

Summary:
* Adding multiweight support for shufflenetv2 prototype models

* Revert "Adding multiweight support for shufflenetv2 prototype models"

This reverts commit 31fadbe.

* Adding multiweight support for shufflenetv2 prototype models

* Revert "Adding multiweight support for shufflenetv2 prototype models"

This reverts commit 4e3d900.

* Adding multiweight support for shufflenetv2 prototype models

* addressing PR comment

Reviewed By: datumbox

Differential Revision: D32064704

fbshipit-source-id: 2c4c4aec955dcb7f2f60a35a1f6059303f7a28ec
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
…4792)

* Adding multiweight support for shufflenetv2 prototype models

* Revert "Adding multiweight support for shufflenetv2 prototype models"

This reverts commit 31fadbe.

* Adding multiweight support for shufflenetv2 prototype models

* Revert "Adding multiweight support for shufflenetv2 prototype models"

This reverts commit 4e3d900.

* Adding multiweight support for shufflenetv2 prototype models

* addressing PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-pretrained weights: Add initial API and basic implementation
3 participants