-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Adding multiweight support for shufflenetv2 prototype model #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit f3efb57 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdsgomes. Overall it looks good, I just spotted one issue that needs to be corrected. Let me know what you think.
Well-spotted , thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…4792) Summary: * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 31fadbe. * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 4e3d900. * Adding multiweight support for shufflenetv2 prototype models * addressing PR comment Reviewed By: datumbox Differential Revision: D32064704 fbshipit-source-id: 2c4c4aec955dcb7f2f60a35a1f6059303f7a28ec
…4792) * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 31fadbe. * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 4e3d900. * Adding multiweight support for shufflenetv2 prototype models * addressing PR comment
Addresses #4672
cc @datumbox @vfdev-5 @bjuncek
PS: apologies for the messy PR!