Adding multiweight support for googlenet prototype model #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit b42bdf6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
commented
Nov 1, 2021
| @@ -25,43 +25,6 @@ | |||
| _GoogLeNetOutputs = GoogLeNetOutputs | |||
|
|
|||
|
|
|||
| def googlenet(pretrained: bool = False, progress: bool = True, **kwargs: Any) -> "GoogLeNet": | |||
There was a problem hiding this comment.
Literally just moving it to the bottom of the file so that we can use proper typing.
| from .shufflenetv2 import * | ||
| from .vgg import * |
There was a problem hiding this comment.
Just reordering stuff and adding googlenet in the list.
| weights = GoogLeNetWeights.ImageNet1K_TheCodezV1 if kwargs.pop("pretrained") else None | ||
| weights = GoogLeNetWeights.verify(weights) | ||
|
|
||
| remove_aux_logits = False |
There was a problem hiding this comment.
Lots of workarounds required by this model. I would appreciate a close review to ensure the new logic is aligned with the previous one.
jdsgomes
reviewed
Nov 1, 2021
jdsgomes
approved these changes
Nov 1, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Move model builder at the bottom of the file, so we can use proper typing. * Adding GoogLeNet with multi-weight support. * Simplify expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #4672
cc @datumbox @bjuncek