Skip to content

Adding multiweight support for squeezenet prototype model #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 1, 2021

Fixes partially #4672

cc @datumbox @bjuncek

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 1, 2021

💊 CI failures summary and remediations

As of commit 8bcf151 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor Author

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one clarification for an unrelated change sneaked in this PR:

@@ -17,7 +17,7 @@


class GoogLeNetWeights(Weights):
ImageNet1K_TheCodezV1 = WeightEntry(
ImageNet1K_Community = WeightEntry(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the enum convention for weights that come from the community and are not part of another library.

Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping.

@datumbox datumbox merged commit bec45cd into pytorch:main Nov 1, 2021
@datumbox datumbox deleted the prototype/squeezenet_multiweight branch November 1, 2021 16:41
@datumbox datumbox linked an issue Nov 1, 2021 that may be closed by this pull request
facebook-github-bot pushed a commit that referenced this pull request Nov 6, 2021
…4817)

Summary:
* Change enum name for weights contributed by community.

* Adding multiweight support to squeezenet.

Reviewed By: kazhang

Differential Revision: D32216671

fbshipit-source-id: 431fc1129407d571e9cdcf4db249a07cd8a98af6
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
* Change enum name for weights contributed by community.

* Adding multiweight support to squeezenet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-pretrained weights: Add initial API and basic implementation
4 participants