-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Adding multiweight support for inception prototype model #4821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multiweight support for inception prototype model #4821
Conversation
💊 CI failures summary and remediationsAs of commit bf5fe2d (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few clarifications:
@@ -26,43 +26,6 @@ | |||
_InceptionOutputs = InceptionOutputs | |||
|
|||
|
|||
def inception_v3(pretrained: bool = False, progress: bool = True, **kwargs: Any) -> "Inception3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the builder at the bottom of the file to use proper typing.
weights = Inception3Weights.ImageNet1K_TFV1 if kwargs.pop("pretrained") else None | ||
weights = Inception3Weights.verify(weights) | ||
|
||
original_aux_logits = kwargs.get("aux_logits", True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to GoogleNet but here the default value is True not False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Moving original builder at the bottom of the page to use proper typing. * Adding multiweight support to inception. * Update doc.
Fixes #4672
cc @datumbox @bjuncek