Skip to content

Adding multiweight support for inception prototype model #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 1, 2021

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 1, 2021

💊 CI failures summary and remediations

As of commit bf5fe2d (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.7_cu111 packaging/build_conda.sh 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.7_cu111

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor Author

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few clarifications:

@@ -26,43 +26,6 @@
_InceptionOutputs = InceptionOutputs


def inception_v3(pretrained: bool = False, progress: bool = True, **kwargs: Any) -> "Inception3":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the builder at the bottom of the file to use proper typing.

weights = Inception3Weights.ImageNet1K_TFV1 if kwargs.pop("pretrained") else None
weights = Inception3Weights.verify(weights)

original_aux_logits = kwargs.get("aux_logits", True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to GoogleNet but here the default value is True not False

Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@datumbox datumbox merged commit 732fc0b into pytorch:main Nov 1, 2021
@datumbox datumbox deleted the prototype/inceptionv3_multiweights branch November 1, 2021 18:12
@datumbox datumbox linked an issue Nov 1, 2021 that may be closed by this pull request
facebook-github-bot pushed a commit that referenced this pull request Nov 6, 2021
)

Summary:
* Moving original builder at the bottom of the page to use proper typing.

* Adding multiweight support to inception.

* Update doc.

Reviewed By: kazhang

Differential Revision: D32216683

fbshipit-source-id: 376853228ff558bc79972e1ff104bf1f227edc20
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
* Moving original builder at the bottom of the page to use proper typing.

* Adding multiweight support to inception.

* Update doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-pretrained weights: Add initial API and basic implementation
3 participants