Skip to content

Moving the check for prototype support in all references #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

Moving the check for prototype support in all references #4849

merged 1 commit into from
Nov 3, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 3, 2021 •
edited by pytorch-probot bot
Loading

Resolving PR comment from #4847 (comment)

Related partially to #4652

cc @datumbox @bjuncek

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 3, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit c5d4234 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.6_cu111 packaging/build_conda.sh 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.6_cu111
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox requested a review from jdsgomes November 3, 2021 15:12
jdsgomes
jdsgomes approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datumbox datumbox merged commit 3300692 into pytorch:main Nov 3, 2021
@datumbox datumbox deleted the references/better_prototype_handling branch November 3, 2021 15:35
@datumbox datumbox linked an issue Nov 3, 2021 that may be closed by this pull request
Multi pretrained weights: Cleanups and Refactoring #4652
Closed
5 tasks
facebook-github-bot pushed a commit that referenced this pull request Nov 8, 2021
@prabhat00155 @facebook-github-bot
[fbsync] Moving the check for prototype support in all references. (#…
27150a9 
…4849)

Reviewed By: kazhang

Differential Revision: D32216666

fbshipit-source-id: 97eee21e32d3946cfca569eaf0dd9f98ea2fce1a
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@datumbox @cyyever
Moving the check for prototype support in all references. (pytorch#4849)
30f2b0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsgomes jdsgomes jdsgomes approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed enhancement module: reference scripts prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi pretrained weights: Cleanups and Refactoring
3 participants
@datumbox @facebook-github-bot @jdsgomes