Skip to content

Adding interpolation in meta for all models and cleaning up unused vars #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2021
Merged

Adding interpolation in meta for all models and cleaning up unused vars #4876

merged 2 commits into from
Nov 6, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Nov 5, 2021 •
edited
Loading

Fix partially #4652

Minor clean ups on all existing models:

  • Adding interpolation info in all missing meta.
  • Removing unused arch var in VGG.

cc @datumbox @bjuncek

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 901c26f (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

2 failures not recognized by patterns:

Job Step Action
CircleCI binary_libtorchvision_ops_android Build 🔁 rerun
CircleCI binary_linux_conda_py3.6_cu111 packaging/build_conda.sh 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.6_cu111
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox requested a review from jdsgomes November 5, 2021 18:03
kazhang
kazhang approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@kazhang kazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit a23778c into pytorch:main Nov 6, 2021
@datumbox datumbox deleted the prototype/interpolation_in_meta branch November 6, 2021 10:01
@datumbox datumbox linked an issue Nov 6, 2021 that may be closed by this pull request
Multi pretrained weights: Cleanups and Refactoring #4652
Closed
5 tasks
facebook-github-bot pushed a commit that referenced this pull request Nov 13, 2021
@kazhang @facebook-github-bot
[fbsync] Adding interpolation in meta for all models and cleaning up …
0a9ff12 
…unnecessary vars. (#4876)

Reviewed By: datumbox

Differential Revision: D32298979

fbshipit-source-id: 096074f6f442589b5c59bd69114289766504be0b
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@datumbox @cyyever
Adding interpolation in meta for all models and cleaning up unnecessa…
9cd0c38 
…ry vars. (pytorch#4876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazhang kazhang kazhang approved these changes

@jdsgomes jdsgomes Awaiting requested review from jdsgomes

Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: models prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi pretrained weights: Cleanups and Refactoring
3 participants
@datumbox @facebook-github-bot @kazhang