Set seed on test_nms_ref to reduce flakiness
#4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 31bd6dd (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
Reviewed By: datumbox Differential Revision: D32470479 fbshipit-source-id: 31d8b9443a0422457d8fd9fd2be5a467c5b02875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_nms_refseems to be flaky. This is related to the unstable sort used by NMS. To resolve this we could fix the seeds. A better solution currently investigated at #4767 is to make the sort stale within NMS.cc @pmeier