Skip to content

add logging for semantic segmentation models #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2021
Merged

add logging for semantic segmentation models #4956

merged 2 commits into from
Nov 22, 2021

Conversation

kazhang
Copy link
Contributor

@kazhang kazhang commented Nov 17, 2021

partially close: #4955

cc @datumbox

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 17, 2021

💊 CI failures summary and remediations

As of commit 06b68dc (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kazhang kazhang requested a review from datumbox November 17, 2021 22:01
@kazhang kazhang changed the title add logging for LRASPP, FCN, DeepPLabV3 add logging for semantic segmentation models Nov 17, 2021
@kazhang kazhang marked this pull request as ready for review November 17, 2021 22:47
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kazhang. The failing tests are unrelated.

Do you plan to send one for the transforms and IO as well?

@datumbox datumbox merged commit 7fa267e into pytorch:main Nov 22, 2021
@kazhang
Copy link
Contributor Author

kazhang commented Nov 22, 2021

Do you plan to send one for the transforms and IO as well?

I would like to try out the ideas in #4957 today first. I will keep you posted.

facebook-github-bot pushed a commit that referenced this pull request Nov 30, 2021
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]>

Reviewed By: NicolasHug

Differential Revision: D32694321

fbshipit-source-id: 83896775434c509f996af9adfc4ea9bc072f5d88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _log_api_usage_once() calls on remaining endpoints
3 participants