use decorator to log API usage #4976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4a004a9 (more details on the Dr. CI page):
🕵️ 5 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 unittest_linux_cpu_py3.8 |
Run tests | 🔁 rerun |
| cmake_macos_cpu |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | |
| sh conda.sh -b | ||
| source $HOME/miniconda3/bin/activate | ||
| conda install -yq conda-build cmake | ||
| packaging/build_cmake.sh | ||
| 🔁 rerun | ||
| cmake_linux_cpu |
packaging/build_cmake.sh | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
|
@kazhang I tried to reproduce the problem locally but I can't. Aka pulling your branch and running the tests doesn't cause issues to me. I'm using pytorch nightly |
NicolasHug
reviewed
Nov 23, 2021
| event = f.__module__ | ||
| if f.__name__.endswith("__init__"): | ||
| # inside module instantiation | ||
| event += args[0].__class__.__name__ |
There was a problem hiding this comment.
I think we'll need a dot in the middle to preserve the previous naming (same below)
Suggested change
| event += args[0].__class__.__name__ | |
| event += "." + args[0].__class__.__name__ |
There was a problem hiding this comment.
Good catch, I addressed in local, but haven't pushed here yet.
@datumbox yes, I tested locally with Python And saw the same failure as in unit test. |
|
I can see now why the tests passed locally. We need to pass the I don't believe decorators will be supported by JIT. I believe what happens is the from torchvision.ops.boxes import box_area,box_iou
import torch
s = torch.jit.script(box_iou)
Traceback (most recent call last):
File "<input>", line 3, in <module>
File "./torch/jit/_script.py", line 1308, in script
ast = get_jit_def(obj, obj.__name__)
File "./torch/jit/frontend.py", line 264, in get_jit_def
return build_def(parsed_def.ctx, fn_def, type_line, def_name, self_name=self_name, pdt_arg_types=pdt_arg_types)
File "./torch/jit/frontend.py", line 302, in build_def
param_list = build_param_list(ctx, py_def.args, self_name, pdt_arg_types)
File "./torch/jit/frontend.py", line 326, in build_param_list
raise NotSupportedError(ctx_range, _vararg_kwarg_err)
torch.jit.frontend.NotSupportedError: Compiled functions can't take variable number of arguments or use keyword-only arguments with defaults:
File "./vision/torchvision/utils.py", line 380
def wrapper(*args, **kwargs):
~~~~~~~ <--- HERE
event = f.__module__
if f.__name__.endswith("__init__"):This is a known limitation for JIT, so I don't think there is any way around it. |
|
Maybe JIT could provide its own version of functools.wraps? Or its own decorator-maker? Worth opening an issue about this in PyTorch core? Various decorators like logging or forced autocasts are useful in many contexts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4957