fix fromfile on windows
#4980
Merged
fix fromfile on windows
#4980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4560946 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
approved these changes
Dec 3, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
Summary: * exclude windows from mmap * add comment for windows * appease mypy Reviewed By: NicolasHug Differential Revision: D32950931 fbshipit-source-id: b5c9a26d791fa040e554f3502625dd206dd64101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, simply calling
mmap.mmap()on a file that doesn't support it on windows, corrupts the internal state and no data can be read anymore. See https://github.com/pytorch/data/runs/4406380310?check_suite_focus=true for an example.Thus, we skip the speedup on Windows entirely.
cc @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @mszhanyi @pmeier @bjuncek