Update test_transforms.py #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve `test_pad_with_non_constant_padding_modes` to avoid data multiplication in `transforms.ToPILImage()` on float data: ```python img = torch.zeros(3, 27, 27) # Float32 img[:, :, 0] = 1 # we add 1 and not 255 img = transforms.ToPILImage()(img) # This converts 1 to 255 due to [pic = pic.mul(255).byte()](https://github.com/pytorch/vision/blob/master/torchvision/transforms/functional.py#L107) ``` and thus test's correct values are [..., 200, 1, 0]
fmassa
approved these changes
May 15, 2018
|
Thanks! |
varunagrawal
pushed a commit
to varunagrawal/vision
that referenced
this pull request
Jul 23, 2018
Improve `test_pad_with_non_constant_padding_modes` to avoid data multiplication in `transforms.ToPILImage()` on float data: ```python img = torch.zeros(3, 27, 27) # Float32 img[:, :, 0] = 1 # we add 1 and not 255 img = transforms.ToPILImage()(img) # This converts 1 to 255 due to [pic = pic.mul(255).byte()](https://github.com/pytorch/vision/blob/master/torchvision/transforms/functional.py#L107) ``` and thus test's correct values are [..., 200, 1, 0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nit improve
test_pad_with_non_constant_padding_modesto avoid data multiplication intransforms.ToPILImage()on float data:However original image value at the boundary is
1and not255.If we modify
img = torch.zeros(3, 27, 27).byte(), then test's correct values are [..., 200, 1, 0] instead of previous [..., 200, 255, 0]