Cleanup namings of Multi-weights classes and enums #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit ecdea1c (more details on the Dr. CI page):
3 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
force-pushed
the
prototype/cleanup_api
branch
2 times, most recently
from
32a2505 to
aca9b51
Compare
datumbox
changed the title
NicolasHug
approved these changes
Nov 29, 2021
datumbox
force-pushed
the
prototype/cleanup_api
branch
from
aca9b51 to
5d3500e
Compare
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
5 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
Summary: * Rename classes Weights => WeightsEnum and WeightEntry => Weights. * Make enum values follow the naming convention `_V1`, `_V2` etc * Cleanup the Enum class naming conventions. * Add a test to check naming conventions. Reviewed By: NicolasHug Differential Revision: D32759196 fbshipit-source-id: 5348a432dc439cad21fbb1db507b21edcbeb7ece
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #4652
Weights => WeightsEnumandWeightEntry => Weights_V1,_V2etccapitalized(model_builder_name) + "_Weights"orcapitalized(model_builder_name) + "_QuantizedWeights".cc @datumbox @bjuncek