Add CUDA-11.5 builds to torchvision #5024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 5307c15 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
atalman
force-pushed
the
main
branch
2 times, most recently
from
3a502d7 to
f410270
Compare
janeyx99
approved these changes
Dec 9, 2021
seemethere
reviewed
Dec 9, 2021
packaging/build_conda.sh
Outdated
| @@ -12,4 +12,4 @@ setup_conda_cudatoolkit_constraint | |||
| setup_visual_studio_constraint | |||
| setup_junit_results_folder | |||
| # nvidia channel included for cudatoolkit >= 11 | |||
| conda build -c defaults -c nvidia $CONDA_CHANNEL_FLAGS --no-anaconda-upload --python "$PYTHON_VERSION" packaging/torchvision | |||
| conda build -c defaults -c conda-forge $CONDA_CHANNEL_FLAGS --no-anaconda-upload --python "$PYTHON_VERSION" packaging/torchvision | |||
There was a problem hiding this comment.
We should be wary about adding conda-forge, iirc this causes a ton more problems with dependencies
seemethere
approved these changes
Dec 9, 2021
|
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
Summary: * Add CUDA-11.5 builds to torchvision * Try to fix cudatoolkit issue * Trying to use cuda11.5 instead of the toolkit * Trying to rollback last two changes * Testing * Using conda-forge only for cuda115 builds * Fix typo Reviewed By: prabhat00155 Differential Revision: D33253481 fbshipit-source-id: ed907034b468c1989343315a13787af553bc0be7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69295 (Add 11.5 to torchvision CI pytorch/pytorch#69295)
One of the issues discovered during this PR is that: conda install -yq -c nvidia -c pytorch cudatoolkit=11.5
Does not work following error is created:
UnsatisfiableError: The following specifications were found to be incompatible with each other:
Output in format: Requested package -> Available versions
Package libgcc-ng conflicts for:
python=3.9 -> libgcc-ng[version='>=7.3.0|>=7.5.0']
python=3.9 -> zlib[version='>=1.2.11,<1.3.0a0'] -> libgcc-ng[version='>=7.2.0']
cudatoolkit=11.5 -> libgcc-ng[version='>=9.4.0']The following specifications were found to be incompatible with your system:
Your installed version is: 2.1
Workaround implemented by using conda-forge chanell
cc @seemethere