-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add GTSRB dataset to the list of supporting datasets #5117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @sumukhaithal6! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
💊 CI failures summary and remediationsAs of commit 297dfd2 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 3 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @sumukhaithal6, this LGTM! Some minor nits inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more nits to appease mypy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @sumukhaithal6 for the PR, and @pmeier for the review!
I made a few comments below, but this looks great already. I realize this has been a while since the last approval so if you'd like me to address these comments myself, just let me know.
CI failure are unrelated so I merged. Thanks a ton @sumukhaithal6 and @pmeier ! |
Summary: * Added GTSRB dataset * Added unittest for GTSRB dataset * Apply suggestions from code review * More changes from code review * readd accidental removed line Reviewed By: sallysyw Differential Revision: D33479282 fbshipit-source-id: 0942e02e5c5459a05536cf49e256c5dcd50c7fec Co-authored-by: Philip Meier <[email protected]>
Addresses GTSRB dataset in #5108.
This PR adds the GTSRB dataset to torchvision.datasets module.
Note: No validation split in this dataset.
Any suggestions/ feedback welcome.
cc: @pmeier @NicolasHug
cc @pmeier