-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Food 101 dataset #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Food 101 dataset #5119
Conversation
This reverts commit 31fadbe.
This reverts commit 4e3d900.
Addresses pytorch#5108. cc @pmeier @NicolasHug
💊 CI failures summary and remediationsAs of commit ed4e0b7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jdsgomes for the PR! I've left a few comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion for the failing tests and some small nits left. Thanks a lot @jdsgomes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After 23f685a the functionality is broken again. My former review was based on the commits before that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (again 😛) if CI is green. Thanks @jdsgomes!
Summary: * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 31fadbe. * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 4e3d900. * Add Food101 Dataset Addresses #5108. cc pmeier NicolasHug * Remove unecessary Path contructor calls * Remove unecessary Path contructor callsi and fix types * Fix tests * Address PR comments from pmeier * Fix bug in tests and in food101 dataset * Fix bug in tests and in food101 dataset * Update torchvision/datasets/food101.py Reviewed By: prabhat00155 Differential Revision: D33351107 fbshipit-source-id: de2a0df07397be82605ee5b700c96297ec3394d5 Co-authored-by: Philip Meier <[email protected]>
Addresses #5108.
cc @pmeier @NicolasHug