remove get_bool_env_var #5222
Merged
remove get_bool_env_var #5222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 75ae574 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Thanks a lot for keeping an open mind on this @pmeier .
LGTM!
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
Reviewed By: jdsgomes, prabhat00155 Differential Revision: D33739382 fbshipit-source-id: 1b06e935aa6ccca183df883232e2957be84f7d29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5184 (comment). After some more offline discussions, @NicolasHug and I found two strong reasons to remove it:
strtoboolfromdistutilswhich is deprecated and will be removed in Python 3.12strtoboolparses typical English true- and false-ish values. Thus, it actually should be namedget_english_bool_env_var, which defeats the purpose I added it in the first place.cc @pmeier