An optimization for WeightsEnum

[yoshitomo-matsubara]

As partly discussed in #5088 with @datumbox, the current WegithsEnum class checks if a given str is a member of the class in an iterative way as follows:

    @classmethod
    def from_str(cls, value: str) -> "WeightsEnum":
        for k, v in cls.__members__.items():
            if k == value:
                return v
        raise ValueError(f"Invalid value {value} for enum {cls.__name__}.")

Since __members__ is an instance of mappingproxy, we can check it in an efficient way like we do with a dict:

    @classmethod
    def from_str(cls, value: str) -> "WeightsEnum":
        if value in cls.__members__:
            return cls.__members__[value]
        raise ValueError(f"Invalid value {value} for enum {cls.__name__}.")

cc @datumbox @bjuncek

[facebook-github-bot]

Hi @yoshitomo-matsubara!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 638f705 (more details on the Dr. CI page):

---

✅ None of the CI failures appear to be your fault 💚

---

• 1/1 broken upstream at merge base 03d1133 since Jan 14

---

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

• unittest_prototype since Jan 14 (adf8466)
  • 🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[datumbox]

@yoshitomo-matsubara LGTM, thanks!

[datumbox]

@yoshitomo-matsubara You will need to complete the CLA before I can merge this. Just follow the bot's instructions at #5225 (comment) :)

[yoshitomo-matsubara]

@datumbox
My pleasure :)

I signed up the CLA with this github account, but they have not recognized it yet

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[yoshitomo-matsubara]

@datumbox
It looks like the bot just recognized my CLA sign up

[datumbox]

@yoshitomo-matsubara Sometimes it takes a bit of time for the bot to "see" the change. Thanks for the contribution!