Skip to content

allow single extension as str in make_dataset #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2022
Merged

allow single extension as str in make_dataset #5229

merged 6 commits into from
Jan 20, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 20, 2022

@pmeier pmeier requested a review from NicolasHug January 20, 2022 11:21
@facebook-github-bot
Copy link

facebook-github-bot commented Jan 20, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 60a3cf3 (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build unittest_windows_gpu_py3.8 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

test/test_utils.py::test_draw_keypoints_errors SKIPPED (We're in a C...) [ 99%] 
test/test_utils.py::test_draw_segmentation_masks[1-blue] SKIPPED (We...) [ 99%]
test/test_utils.py::test_draw_segmentation_masks[1-#FF00FF] SKIPPED      [ 99%]
test/test_utils.py::test_draw_segmentation_masks[1-colors3] SKIPPED      [ 99%]
test/test_utils.py::test_draw_segmentation_masks[1-colors4] SKIPPED      [ 99%]
test/test_utils.py::test_draw_segmentation_masks[1-colors5] SKIPPED      [ 99%]
test/test_utils.py::test_draw_segmentation_masks_errors SKIPPED (We'...) [ 99%]
test/test_utils.py::test_draw_keypoints_vanilla SKIPPED (We're in a ...) [ 99%]
test/test_utils.py::test_draw_keypoints_colored[red] SKIPPED (We're ...) [ 99%]
test/test_utils.py::test_draw_keypoints_colored[#FF00FF] SKIPPED (We...) [ 99%]
test/test_utils.py::test_draw_keypoints_colored[colors2] SKIPPED (We...) [ 99%]
test/test_utils.py::test_draw_keypoints_errors SKIPPED (We're in a C...) [ 99%]
test/test_video_gpu_decoder.py::TestVideoGPUDecoder::test_frame_reading SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_stress_test_read_video_from_file SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_read_single_stream_only SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_min_dimension SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_max_dimension SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_both_min_max_dimension SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_width SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_height SKIPPED [ 99%]
test/test_video_reader.py::TestVideoReader::test_read_video_from_file_rescale_width_and_height SKIPPED [ 99%]

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

pmeier
pmeier commented Jan 20, 2022
View reviewed changes
test/test_datasets_utils.py Outdated
],
)
def test_make_dataset_no_valid(self, tmpdir, kwargs, expected_error_msg):
tmpdir = pathlib.Path(tmpdir)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, that tmpdir is not a pathlib.Path, but rather a custom type which acts somewhat like a pathlib.Path. Still, methods like .touch do not exists, so we cast here.

pmeier
pmeier commented Jan 20, 2022
View reviewed changes
NicolasHug
NicolasHug approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier , I'm going to approve to unlock but since we'll likely not use that utility anymore, I'm not convinced this is strongly needed

@pmeier pmeier merged commit 6512146 into pytorch:main Jan 20, 2022
@pmeier pmeier deleted the fix-ext-annotation branch January 20, 2022 15:14
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jan 26, 2022
@datumbox @facebook-github-bot
[fbsync] allow single extension as str in make_dataset (#5229)
ddd3111 
Summary:
* allow single extension as str in make_dataset

* remove test class

* remove regex

* revert collection to tuple

* cleanup

Reviewed By: jdsgomes, prabhat00155

Differential Revision: D33739394

fbshipit-source-id: 460a1576a18d9ee61657302c10b3e51156cd66fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed code quality module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmeier @facebook-github-bot @NicolasHug @jdsgomes