Skip to content

Removed unused member functions from GPU decoder #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

prabhat00155
Copy link
Contributor

References to these member functions were removed as a result of #5191.
Partly addresses #5205.

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 1, 2022

💊 CI failures summary and remediations

As of commit 938f4a2 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build CodeQL / build (1/1)

Step: "Build TorchVision" (full log | diagnosis details | 🔁 rerun)

2022-02-01T13:07:55.3295121Z ##[error]Process completed with exit code 1.
2022-02-01T13:07:55.1637264Z     self.finalize_options()
2022-02-01T13:07:55.1638024Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/develop.py", line 52, in finalize_options
2022-02-01T13:07:55.1638933Z     easy_install.finalize_options(self)
2022-02-01T13:07:55.1639695Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 276, in finalize_options
2022-02-01T13:07:55.1640317Z     self._fix_install_dir_for_user_site()
2022-02-01T13:07:55.1691836Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 382, in _fix_install_dir_for_user_site
2022-02-01T13:07:55.1692206Z     self.create_home_path()
2022-02-01T13:07:55.1692870Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1338, in create_home_path
2022-02-01T13:07:55.1693270Z     if path.startswith(home) and not os.path.isdir(path):
2022-02-01T13:07:55.1693668Z AttributeError: 'int' object has no attribute 'startswith'
2022-02-01T13:07:55.3295121Z ##[error]Process completed with exit code 1.
2022-02-01T13:07:55.3350428Z Post job cleanup.
2022-02-01T13:07:55.4536332Z [command]/usr/bin/git version
2022-02-01T13:07:55.4592185Z git version 2.34.1
2022-02-01T13:07:55.4624676Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-02-01T13:07:55.4672292Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-02-01T13:07:55.5030766Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-02-01T13:07:55.5068211Z http.https://github.com/.extraheader
2022-02-01T13:07:55.5080264Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2022-02-01T13:07:55.5127934Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2022-02-01T13:07:55.5696004Z Cleaning up orphan processes

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , stamping

@prabhat00155 prabhat00155 merged commit 5b82590 into pytorch:main Feb 1, 2022
@prabhat00155 prabhat00155 deleted the prabhat00155/code_cleanup branch February 1, 2022 13:06
facebook-github-bot pushed a commit that referenced this pull request Feb 3, 2022
Summary: remove unused code.

Reviewed By: kazhang

Differential Revision: D33927510

fbshipit-source-id: 118a9d59e2a9034d1c12a30fe0fc86b022f3b752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants