Skip to content

Base for places365 #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Base for places365 #5383

wants to merge 5 commits into from

Conversation

Amapocho
Copy link

@Amapocho Amapocho commented Feb 7, 2022

Added necessary links and categories as a starting point for places365 #5347

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 7, 2022

💊 CI failures summary and remediations

As of commit cc2aa8c (more details on the Dr. CI page):



🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build unittest_prototype (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

/home/circleci/project/test/test_prototype_feat...ead to errors or silently give incorrect results).
test/test_prototype_utils.py::test_sequence_to_str[seq5-and -'foo', 'bar', and 'baz'] �[32mPASSED�[0m�[31m [100%]�[0m

=================================== FAILURES ===================================
�[31m�[1m________________________________ test_coverage _________________________________�[0m
Traceback (most recent call last):
  File "/home/circleci/project/test/test_prototype_builtin_datasets.py", line 24, in test_coverage
    f"The dataset(s) {sequence_to_str(sorted(untested_datasets), separate_last='and ')} "
AssertionError: The dataset(s) 'places365' are exposed through `torchvision.prototype.datasets.load()`, but are not tested. Please add mock data to `test/builtin_dataset_mocks.py`.
�[33m=============================== warnings summary ===============================�[0m
test/test_prototype_features.py::TestJit::test_bounding_box
  /home/circleci/project/test/test_prototype_features.py:150: TracerWarning: Iterating over a tensor might cause the trace to be incorrect. Passing a tensor of different shape won't change the number of iterations executed (and might lead to errors or silently give incorrect results).
    new_height, new_width = size

test/test_prototype_features.py::TestJit::test_bounding_box
  /home/circleci/project/torchvision/prototype/features/_feature.py:78: TracerWarning: torch.as_tensor results are registered as constants in the trace. You can safely ignore this warning if you use this function to create tensors out of constant variables that would be the same every time you call this function. In any other case, this might cause the trace to be incorrect.
    return torch.as_tensor(data, dtype=dtype, device=device)

test/test_prototype_features.py::TestJit::test_bounding_box
  /home/circleci/project/test/test_prototype_features.py:164: TracerWarning: Converting a tensor to a Python list might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
    new_x1, new_y1, new_x2, new_y2, like=input, format="xyxy", image_size=tuple(size.tolist())


🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier pmeier self-requested a review February 7, 2022 16:03
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amapocho thanks a lot for the PR so other might use it as base for their work. I've added a cleanup commit that might also be beneficial for you to look at.

@pmeier pmeier mentioned this pull request Feb 7, 2022
@pmeier
Copy link
Collaborator

pmeier commented Mar 28, 2022

Superseded by #5679.

@pmeier pmeier closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants