Move VideoReader out of __init__ #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit da0bbfe (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
@prabhat00155 I understand that this is just a refactoring/moving out code to a separate file. If that's the case, I'm stumping to unblock.
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Summary: * Move VideoReader out of __init__ * Fix linter error Reviewed By: datumbox Differential Revision: D34579516 fbshipit-source-id: 32a56417f4cacf1ae20d8cab605911f84e6ec525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a separate file for VideoReader class and clean up
__init__.py.More information: #5019 (comment)
Partly addresses: #5148