-
Notifications
You must be signed in to change notification settings - Fork 7.1k
improve StrEnum #5512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve StrEnum #5512
Conversation
💊 CI failures summary and remediationsAs of commit d990996 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but it's blocked by the dependency on the internal of prototype. See comment below. Thoughts?
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * improve StrEnum * use StrEnum for model weights * fix test * migrate StrEnum to main area Reviewed By: vmoens Differential Revision: D34878985 fbshipit-source-id: 6a37cb694a3fcc55fa39382b59a1c7e65edacd5e
This adds a
from_str
class method toStrEnum
to clean up the interface. This seems to be fully scriptable