NOMRG Models docs revamp -- v2 #5577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 2503263 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
commented
Mar 10, 2022
| @@ -304,36 +305,81 @@ class Wide_ResNet101_2_Weights(WeightsEnum): | |||
| DEFAULT = IMAGENET1K_V2 | |||
|
|
|||
|
|
|||
| # It may or may not be a good idea to somehow unify that with _VGG_DOC . It's | |||
| # too early to decide yet. | |||
| _RESNET_DOC = """ResNet-{num_layers} from `Deep Residual Learning for Image Recognition <https://arxiv.org/pdf/1512.03385.pdf>`__. | |||
There was a problem hiding this comment.
Please ignore _RESNET_DOC, it's not used anywhere and is replaced by _make_resnet_docstring. Will remove
NicolasHug
commented
Mar 10, 2022
| allowed_values = ", ".join(f"``{v}``" for v in weights) | ||
|
|
||
| return f"""ResNet-{suffix} from `Deep Residual Learning for Image Recognition <https://arxiv.org/pdf/1512.03385.pdf>`__. | ||
| Image Recognition <https://arxiv.org/abs/1409.1556>`__. |
There was a problem hiding this comment.
TODO
Suggested change
| Image Recognition <https://arxiv.org/abs/1409.1556>`__. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5575, adding documentation for the Weight enums.
The Weight docs is embedded in the same page as their corresponding model builders: https://1256058-73328905-gh.circle-artifacts.com/0/docs/prototype_models/generated/torchvision.prototype.models.resnet50.html#torchvision.prototype.models.resnet50
