Skip to content

remove option to pass fill as str #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2022
Merged

remove option to pass fill as str #5632

merged 2 commits into from
Mar 17, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 16, 2022 •
edited
Loading

Closes #5627.

@pmeier pmeier requested a review from datumbox March 16, 2022 14:22
@facebook-github-bot
Copy link

facebook-github-bot commented Mar 16, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit e2aa359 (more details on the Dr. CI page):

  • 10/10 failures introduced in this PR

10 failures not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.10_cu102 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.7_cu113 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.10_cu113 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.9_cu102 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.7_cu102 packaging/build_conda.sh 🔁 rerun
CircleCI unittest_linux_gpu_py3.8 Install torchvision 🔁 rerun
CircleCI binary_linux_conda_py3.9_cu113 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.8_cu113 packaging/build_conda.sh 🔁 rerun
CircleCI binary_linux_conda_py3.8_cu102 packaging/build_conda.sh 🔁 rerun
CircleCI cmake_linux_gpu Build torchvision C++ distribution and test 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox added the bug label Mar 17, 2022
@datumbox datumbox merged commit 39772ec into pytorch:main Mar 17, 2022
@pmeier pmeier deleted the transforms/fill branch March 17, 2022 13:31
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@jdsgomes @datumbox @facebook-github-bot
[fbsync] remove option to pass fill as str (#5632)
c746df7 
Summary:

(Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216764

fbshipit-source-id: d03b971e8e654ae3b917dd428afee916eb40939b

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
bug ciflow/default cla signed module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F.pad is broken for PIL images and fill: str
3 participants
@pmeier @facebook-github-bot @datumbox