port image type conversion transforms to prototype API #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit ec1622c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Mar 18, 2022
There was a problem hiding this comment.
The overarching question is: do we want to have a ConvertImageType transform that takes all kind of image types and converts them to a fixed format? That could unify all three of the transforms below. As output formats, I would only allow tensor and PIL images for now.
pmeier
commented
Mar 23, 2022
torchvision/prototype/transforms/functional/_type_conversion.py
Outdated
Show resolved
Hide resolved
vfdev-5
reviewed
Mar 28, 2022
Conflicts: torchvision/prototype/transforms/__init__.py
datumbox
reviewed
Apr 1, 2022
Conflicts: torchvision/prototype/transforms/__init__.py
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: * port image type conversion transforms to prototype API * implement proposal for image type conversion * add deprecation warnings * appease mypy Reviewed By: NicolasHug Differential Revision: D35393162 fbshipit-source-id: e1be4ecfc2c018d24431e66da7d98d32967944a1 Co-authored-by: Vasilis Vryniotis <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 1-to-1 port of the old transformations. This should serve as discussion basis.