support confirming no virus scan on GDrive download #5645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4d0980d (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 2 ongoing upstream failures:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Mar 18, 2022
| @@ -28,27 +28,24 @@ | |||
| USER_AGENT = "pytorch/vision" | |||
|
|
|||
|
|
|||
| def _urlretrieve(url: str, filename: str, chunk_size: int = 1024) -> None: | |||
There was a problem hiding this comment.
Both this function and _save_response_content below had the same functionality, so I factored it out.
| @@ -202,70 +208,41 @@ def download_file_from_google_drive(file_id: str, root: str, filename: Optional[ | |||
| """ | |||
| # Based on https://stackoverflow.com/questions/38511444/python-download-files-from-google-drive-using-url | |||
There was a problem hiding this comment.
Maybe we can drop this comment at some point, because our implementation no longer resembles the answer in the link.
NicolasHug
reviewed
Apr 1, 2022
Co-authored-by: Nicolas Hug <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: * support confirming no virus scan on GDrive download * put gen_bar_updater back * Update torchvision/datasets/utils.py Reviewed By: NicolasHug Differential Revision: D35393174 fbshipit-source-id: 6a0977169f46dad3156c9bd60f13cf4a7ace176b Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>
This was referenced Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5615.