Skip to content

add instructions how to add tests for prototype datasets #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2022
Merged

add instructions how to add tests for prototype datasets #5666

merged 2 commits into from
Mar 23, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 23, 2022 •
edited
Loading

Rendered version. @NicolasHug In #5214 you split long lines, but did so for a line length of 80 characters. In general we use 120 characters:

vision/setup.cfg

Line 8 in be462be

max-line-length = 120

I've fixed the format accordingly. Let me know if we want to use a different line length.

@pmeier pmeier requested a review from NicolasHug March 23, 2022 12:51
@facebook-github-bot
Copy link

facebook-github-bot commented Mar 23, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 769b2e6 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NicolasHug
NicolasHug approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier

@pmeier pmeier merged commit 65d3a87 into pytorch:main Mar 23, 2022
@pmeier pmeier deleted the datasets/readme-tests branch March 23, 2022 13:15
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@jdsgomes @facebook-github-bot
[fbsync] add instructions how to add tests for prototype datasets (#5666
63b6086 
)

Summary: (Note: this ignores all push blocking failures!)

Reviewed By: datumbox

Differential Revision: D35216796

fbshipit-source-id: 75768df023ea5c00111e0a6df18fffb7d91f4891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: datasets prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @facebook-github-bot @NicolasHug