Skip to content

keep imagenet prototype as class but factor out methods #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 29, 2022

In pytorch/data#237 we found that it shouldn't be a fundamental issue with the design that would keep us from using methods as inputs for datapipes defined on the same object. Still, this PR factors out these methods into standalone functions to see if there are more blockers down the road.

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 29, 2022

💊 CI failures summary and remediations

As of commit 8230090 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier
Copy link
Collaborator Author

pmeier commented Apr 7, 2022

Superseded by #5778.

@pmeier pmeier closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants