Skip to content

Add docs for SomeWeight.DEFAULT fields #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 19, 2022

Conversation

NicolasHug
Copy link
Member

Follow up to #5821, this PR adds docs to indicate which weight is equivalent to the DEFAULT field:

image

(I also added a docstring to the hook that generates these docs.)

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@NicolasHug NicolasHug merged commit e8cb0ba into pytorch:main Apr 19, 2022
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
Summary:
* First PR for model doc revamp

* Deactivating fail on warning, temporarily

* Remove commnet

* Minor changes

* Typos

* Added TODO in Makefile

* Keep old models.rst file intact, move new docs into new models_new.rst file

* Added docs LOL

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095660

fbshipit-source-id: d0df99cc20418a15754ac65e4b731ac155d5fc22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants