-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add docs for SomeWeight.DEFAULT
fields
#5831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doc_revamp_letsgo
vmoens
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2022
Summary: * First PR for model doc revamp * Deactivating fail on warning, temporarily * Remove commnet * Minor changes * Typos * Added TODO in Makefile * Keep old models.rst file intact, move new docs into new models_new.rst file * Added docs LOL Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095660 fbshipit-source-id: d0df99cc20418a15754ac65e4b731ac155d5fc22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5821, this PR adds docs to indicate which weight is equivalent to the
DEFAULT
field:(I also added a docstring to the hook that generates these docs.)