-
Notifications
You must be signed in to change notification settings - Fork 7.1k
add Windows and macOS CI jobs for prototype tests #5914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bf024cd
add Windows and macOS CI jobs for prototype tests
pmeier b61e66f
fix CircleCI config
pmeier 01e98ac
cleanup
pmeier 9aa270b
use 3.8 as base to surface errors
pmeier 6b06774
try using bash explicitly
pmeier c50745d
cleanup
pmeier 8421129
try test reports
pmeier a6c911f
debug
pmeier 55996a1
disable CircleCI
pmeier 58db6fa
add write permissions for write
pmeier 290b910
expand permissions
pmeier d93a342
try move permissions on job rather than global
pmeier 01dd40c
debug
pmeier bcf529a
always debug
pmeier f7d6735
maximum permissions
pmeier 5a508f1
cleanup
pmeier a5213c6
cleanup
pmeier 9c35b4f
Merge branch 'main' into prototype-ci
pmeier 0dc857e
Merge branch 'main' into prototype-ci
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: tests | ||
|
||
on: | ||
pull_request: | ||
|
||
jobs: | ||
prototype: | ||
strategy: | ||
matrix: | ||
os: | ||
- ubuntu-latest | ||
- windows-latest | ||
- macos-latest | ||
fail-fast: false | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
||
steps: | ||
- name: Set up python | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: 3.7 | ||
|
||
- name: Upgrade system packages | ||
run: python -m pip install --upgrade pip setuptools wheel | ||
|
||
- name: Checkout repository | ||
uses: actions/checkout@v3 | ||
|
||
- name: Install PyTorch nightly builds | ||
run: pip install --progress-bar=off --pre torch torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu/ | ||
|
||
- name: Install torchvision | ||
run: pip install --progress-bar=off --no-build-isolation --editable . | ||
|
||
- name: Install other prototype dependencies | ||
run: pip install --progress-bar=off scipy pycocotools h5py iopath | ||
|
||
- name: Install test requirements | ||
run: pip install --progress-bar=off pytest pytest-mock | ||
|
||
- name: Run prototype tests | ||
shell: bash | ||
run: pytest --durations=20 test/test_prototype_*.py | ||
vfdev-5 marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking Nit: The fact that we have to add the dependency definition in yet another place is far from ideal. We should look into options to centralize them. Not sure how easy this is to achieve across pip and conda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
conda
vs.pip
will be a problem. Otherwise I'll tackle this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well having them in 2 places is still better than having them in 10. So even if we need 2 different approaches, it's still worth investigating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember the details but I think scikit-learn maintains its dependencies in a centralized place https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/_min_dependencies.py. We could take inspiration from that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open an issue with all our requirements to discuss what would be the best way to address this.