Skip to content

docs: Added FCN to the new doc #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 3, 2022
Merged

docs: Added FCN to the new doc #5915

merged 6 commits into from
May 3, 2022

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Apr 28, 2022

Following up on #5897, this PR introduces the following modifications:

  • creates the new rst doc file for FCN
  • adds the reference on the new page
  • updates the docstring accordingly

Any feedback is welcome!

cc @NicolasHug @datumbox

NicolasHug
NicolasHug previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm !!

@NicolasHug NicolasHug dismissed their stale review April 28, 2022 13:59

missing attributes

NicolasHug
NicolasHug approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frgfm !

@NicolasHug NicolasHug merged commit 2942bfa into pytorch:main May 3, 2022
@NicolasHug NicolasHug mentioned this pull request May 3, 2022
Closed
7 tasks
@frgfm frgfm deleted the fcn-doc branch May 3, 2022 12:59
facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
@YosuaMichael @oke-aditya
@NicolasHug @facebook-github-bot
[fbsync] docs: Added FCN to the new doc (#5915)
baee41c 
Summary:
* docs: Added FCN to new doc

* docs: Updated docstring

* docs: Fixed docstring

* Update docs/source/models/fcn.rst

* Apply suggestions from code review

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095707

fbshipit-source-id: f8c9baa10936283efe9a1eaa151c6a79f64195a1

Co-authored-by: Aditya Oke <[email protected]>
Co-authored-by: FG Fernandez <�[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Aditya Oke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oke-aditya oke-aditya oke-aditya left review comments

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frgfm @NicolasHug @oke-aditya @facebook-github-bot