Skip to content

Remove jpeg dep for type-checking #5943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Remove jpeg dep for type-checking #5943

merged 1 commit into from
May 4, 2022

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 4, 2022 •
edited
Loading

Not sure why this was ever needed, let's see if CI goes red(er)

EDIT: the type_check_python job is green, so this should be good to go

pmeier
pmeier approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that the very first version of this workflow mirrored a different one that installed this. Anyway, happy to remove if it is no longer needed. Thanks Nicolas!

@NicolasHug NicolasHug merged commit 522e9e1 into pytorch:main May 4, 2022
facebook-github-bot pushed a commit that referenced this pull request May 7, 2022
@jdsgomes @facebook-github-bot
[fbsync] Remove jpeg dep for type-checking (#5943)
4208fd9 
Reviewed By: YosuaMichael

Differential Revision: D36204386

fbshipit-source-id: 7c8a712a730507230a16b09b59c8e6c4caec644b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @pmeier @facebook-github-bot