Document ResNet architecture tweak #5977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note for resnet architecture
datumbox
reviewed
May 9, 2022
torchvision/models/resnet.py
Outdated
| while original implementation places the stride at the first 1x1 convolution(self.conv1) | ||
| according to "Deep residual learning for image recognition"https://arxiv.org/abs/1512.03385. | ||
| This variant is also known as ResNet V1.5 and improves accuracy according to | ||
| https://ngc.nvidia.com/catalog/model-scripts/nvidia:resnet_50_v1_5_for_pytorch. |
There was a problem hiding this comment.
This is added on the wrong place. ResNet18 and 34 use the basic BasicBlock not Bottleneck. It's the 50, 101 and 152 versions of the model that use the Bottleneck class.
There was a problem hiding this comment.
Sorry, let me correct soon !
datumbox
reviewed
May 10, 2022
|
@datumbox I'm having errors with unittest_onnx which I did not change. Could you give me some clue to resolve this error. Or is there any other reason that cause the error? |
|
@puhuk that's not something you broke. The main branch is also failing. Feel free to ignore it. |
datumbox
reviewed
May 12, 2022
|
The failures on the CI are due to the |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
Summary: * To resolve issue #5964 Add note for resnet architecture * Update resnet.py * Update resnet.py * Update resnet.rst * Fix stylings * Add the same notes on model builders * Improve description * Apply the change everywhere * Remove trailing space Reviewed By: NicolasHug Differential Revision: D36760934 fbshipit-source-id: 044ff1d1f35f6354dbc7608a0d30951aa90190a2 Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note for resnet architecture
Closes #5964