-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Reinstate and deprecate model_urls
and quant_model_urls
#5992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @datumbox , LGTM. Just some nits
Co-authored-by: Nicolas Hug <[email protected]>
model_urls
and quant_model_urls
model_urls
and quant_model_urls
model_urls
and quant_model_urls
model_urls
and quant_model_urls
All failures are unrelated. Merging. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 24, 2022
…5992) Summary: * Reinstate and deprecate `model_urls` and `quant_model_urls` * Apply suggestions from code review * Move todo location * Add alexnet * Add densenet * Add efficientnet * Add googlenet. * Add inception. * Add mobilenetv3 * Add regnet * Add resnet * Add shufflenetv2 * Fix linter * Add squeezenet * Add vgg * Add vit * Add quantized googlenet * Add quantized inceptionv3 * Add quantized mobilenet_v3 * Add quantized resnet * Add quantized shufflenetv2 * Fix incorrect imports * Add faster_rcnn * Add fcos * Add keypoint rcnn * Add mask rcnn * Add retinanet * Add ssd * Add ssdlite * Add deeplabv3 * Add fcn * Add lraspp. * Add video resnet * Removing weights for shufflenetv2_x1.5 and shufflenetv2_x2.0 * Update the comments Reviewed By: datumbox Differential Revision: D36413362 fbshipit-source-id: 56d6855a77e17db457542cb1c12373a1a881b46b Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
deprecation
module: models.quantization
Issues related to the quantizable/quantized models
module: models
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5836
This PR:
model_urls
/quant_model_urls
dictionaries and deprecates its usages. We do this ONLY for the models that used dictionaries with names that didn't start with_
and existed in version v0.12. We don't include any new model builders or weights on the deprecation dictionary.Verified with: