Skip to content

Replacing cudatoolkit by cuda for 11.6 #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2022
Merged

Replacing cudatoolkit by cuda for 11.6 #5996

merged 1 commit into from
Jun 20, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented May 11, 2022

Replacing cudatoolkit by cuda for 11.6

@datumbox
Copy link
Contributor

@atalman Thanks for the update. Some tests are failing. Is it because the nightly hasn't caught up with the necessary changes yet?

@atalman
Copy link
Contributor Author

atalman commented May 20, 2022

@datumbox Hi Vasilis, these changes are not yet in nightly, will merge pytorch and builder changes after domain libraries branch cut

@NicolasHug NicolasHug mentioned this pull request May 23, 2022
Closed
9 tasks
@datumbox
Copy link
Contributor

@atalman Sounds good. Feel free to merge when you are ready. Thanks for the clarifications.

@atalman atalman closed this Jun 18, 2022
@atalman atalman reopened this Jun 18, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 18, 2022

We have recently simplified the CIFlow labels and ciflow/default is no longer in use.
You can use any of the following

  • ciflow/trunk (.github/workflows/trunk.yml): all jobs we run per-commit on master
  • ciflow/periodic (.github/workflows/periodic.yml): all jobs we run periodically on master
  • ciflow/android (.github/workflows/run_android_tests.yml): android build and test
  • ciflow/nightly (.github/workflows/nightly.yml): all jobs we run nightly
  • ciflow/binaries: all binary build and upload jobs
  • ciflow/binaries_conda: binary build and upload job for conda
  • ciflow/binaries_libtorch: binary build and upload job for libtorch
  • ciflow/binaries_wheel: binary build and upload job for wheel

@atalman atalman force-pushed the vision_conda_forge branch from 721dc1e to 688257e Compare June 18, 2022 16:21
datumbox
datumbox approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @atalman. Feel free to merge when all tests pass and changes appear on the nightly. Do we need to cherrypick these on the main branch?

@atalman
Copy link
Contributor Author

atalman commented Jun 20, 2022

LGTM, thanks @atalman. Feel free to merge when all tests pass and changes appear on the nightly. Do we need to cherrypick these on the main branch?

@datumbox Thank you for approving. No need to cherry-pick these since this change is not going going for release now. We need more testing time.

@atalman atalman merged commit d0d7058 into pytorch:main Jun 20, 2022
@github-actions
Copy link

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@YosuaMichael @facebook-github-bot
[fbsync] Replacing cudatoolkit by cuda for 11.6 (#5996)
c653b60 
Reviewed By: datumbox

Differential Revision: D37375004

fbshipit-source-id: 530c6215eaa890292149317c084f3f6346842e03
atalman added a commit to atalman/vision that referenced this pull request Jul 26, 2022
@atalman
Replacing cudatoolkit by cuda for 11.6 (pytorch#5996)
96f2ede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed cuda topic: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @datumbox @NicolasHug @facebook-github-bot